-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwdef:correct JFB110 defaults #25591
Conversation
Thanks for this. So @Hwurzburg's PR from two weeks ago removed this. Sorry about that, I should have gotten your approval before we merged it. I guess you've checked this change and you're sure that these lines are required in order for RC input to work? |
@rmackay9 We have verified that this feature works. Most of our customers use S.BUS. Thank you. |
@jfbblue0922 SBUS should work fine on the PPM input since its timer interrupt based,as will any unidirectional RC protocol....designating SERIAL5 RX as RCIN does not really enhance the user experience since any RC protocol that it can detect, PPM input will detect. just a note: SERIAL6 as SBUS out is a common function on high end autopilot's, so I think its a good choice, but there a other commonly used TX pin only functions in ArduPilot, like SmartAudio...just fyi |
If you don't have a UART dedicated to RCIN, it would be better to describe in the spec that you don't have RCIN and let the user set up UART5. MULTI PROPO WIKI If there is no RCIN, it can be handled by setting MULTI PROPO. |
Thank you for your comment. For JFB-110, many customers use serial 5 as RCIN. @Hwurzburg @muramura |
setting this has no impact on on the PPM pins functionality....since you insist on this, I will change the documentation when it is merged.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are not needed for SBUS and will make other rc systems fail on this pin
Co-authored-by: Randy Mackay <[email protected]>
2b4a5dd
to
8e1b452
Compare
addressed HenryW's requests, txs for the review.
Serial 5 of JFB110 has only input and is designed for RCIN. So we would like to set default parameters for serial 5.