Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwdef:correct JFB110 defaults #25591

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jfbblue0922
Copy link
Contributor

Serial 5 of JFB110 has only input and is designed for RCIN. So we would like to set default parameters for serial 5.

@rmackay9
Copy link
Contributor

@jfbblue0922,

Thanks for this. So @Hwurzburg's PR from two weeks ago removed this. Sorry about that, I should have gotten your approval before we merged it.

I guess you've checked this change and you're sure that these lines are required in order for RC input to work?

@jfbblue0922
Copy link
Contributor Author

@rmackay9
Thank you for the reply.

We have verified that this feature works.

Most of our customers use S.BUS.
This SERIAL5 with input only is hard to use for other functions, we would like to improve its convenience.
The same goes for SERIAL6 with output only.

Thank you.

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Nov 21, 2023

@jfbblue0922 SBUS should work fine on the PPM input since its timer interrupt based,as will any unidirectional RC protocol....designating SERIAL5 RX as RCIN does not really enhance the user experience since any RC protocol that it can detect, PPM input will detect.
Normally, the UART RCin protocol is used with a full UART(RX and TX) for the bi-directional protocols like CRSF/ELRS,SRXL2,etc...personally, I think defaulting that pin to RC will be a little confusing...Since only its RX is pinned out, it will more likely find use as ESC telem in, or RPM,etc.
Its your autopilot, and if you wish to set its default to RCIN protocol is your choice we will, of course. It will indeed function that way (although it loses the PPM ability) but it's not needed to support SBUS (as I have noted in its documentation on the wiki), and might be a little confusing(although I can update the wiki doc to explain that it could be used as a second RC receiver input for the unidirectional protocols except PPM..although you could do that on any UART)

just a note: SERIAL6 as SBUS out is a common function on high end autopilot's, so I think its a good choice, but there a other commonly used TX pin only functions in ArduPilot, like SmartAudio...just fyi

@muramura
Copy link
Contributor

muramura commented Nov 21, 2023

If you don't have a UART dedicated to RCIN, it would be better to describe in the spec that you don't have RCIN and let the user set up UART5.
UART5 is a general-purpose UART.
It is up to the user to decide how to use it.

MULTI PROPO WIKI
https://ardupilot.org/copter/docs/common-multiple-rx.html

If there is no RCIN, it can be handled by setting MULTI PROPO.
I think it is better to describe the propo setting for available UARTs in the manual.

@jfbblue0922
Copy link
Contributor Author

Thank you for your comment.

For JFB-110, many customers use serial 5 as RCIN.
That's why we would like to configure it with default parameters.

@Hwurzburg
Will it lose PPM functionality if I set the parameter to PCIN ?
Could you please tell me the parameter settings that allow me to use both S.BUS and PPM ?

@muramura
JFB-110 is designed to use Serial 5 as RCIN.
(Of course, you can also use it as a separate function by setting the parameters yourself.)

@Hwurzburg
Copy link
Collaborator

setting this has no impact on on the PPM pins functionality....since you insist on this, I will change the documentation when it is merged..

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are not needed for SBUS and will make other rc systems fail on this pin

@khancyr khancyr added the hwdef label Nov 24, 2023
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Nov 27, 2023
@rmackay9 rmackay9 force-pushed the master_JFB110_hwdef branch from 2b4a5dd to 8e1b452 Compare November 28, 2023 05:40
@rmackay9 rmackay9 dismissed Hwurzburg’s stale review November 28, 2023 05:41

addressed HenryW's requests, txs for the review.

@rmackay9 rmackay9 merged commit c16e1a2 into ArduPilot:master Nov 28, 2023
@jfbblue0922 jfbblue0922 deleted the master_JFB110_hwdef branch November 30, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants