Periph: enable Network Socket to UART passthrough #25595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicrub
force-pushed
the
pr/networking8_periph
branch
from
044ca22 to
a4b8d71
Compare
tridge
requested changes
Nov 22, 2023
magicrub
force-pushed
the
pr/networking8_periph
branch
3 times, most recently
from
dffd984 to
50c9538
Compare
|
I tested, and fixed, the docs using Peter's PR #25613 which really helped. |
Ryanf55
previously requested changes
Nov 22, 2023
magicrub
force-pushed
the
pr/networking8_periph
branch
from
50c9538 to
6b0f485
Compare
| return; | ||
| } | ||
|
|
||
| // Fastest possible connection is 3Mbps serial port, which is roughly 300KB/s payload and we service this at <= 1kHz |
There was a problem hiding this comment.
Hi, How do we come to this number of 3Mbps?
There was a problem hiding this comment.
UARTs can't really go higher than that reliably. Is there a different number you're thinking? Bigger/smaller?
There was a problem hiding this comment.
UARTs can't really go higher than that reliably. Is there a different number you're thinking? Bigger/smaller?
No, I was just wondering if there is any theoretical way to derive it.
tridge
approved these changes
Nov 23, 2023
|
@magicrub looks good to me, just need to get it all OK in CI and param gen |
magicrub
force-pushed
the
pr/networking8_periph
branch
2 times, most recently
from
f636c0f to
63dd5ee
Compare
magicrub
force-pushed
the
pr/networking8_periph
branch
from
63dd5ee to
1aa88d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Network Socket to UART passthrough
This allows a periph to be a UART to IP/Ethernet converter!
Needs more docs..