Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Motors: Heli: dual and quad: remove un-needed override methods #25604

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

IamPete1
Copy link
Member

AP_MotorsHeli_Quad and AP_MotorsHeli_Dual both inherit from AP_MotorsHeli which implements the same methods. There is no need to override.

// has_flybar - returns true if we have a mechical flybar
virtual bool has_flybar() const { return AP_MOTORS_HELI_NOFLYBAR; }

// supports_yaw_passthrough
virtual bool supports_yaw_passthrough() const { return false; }

Alternately we could make the base class a pure virtual so the child class must implement.

Copy link
Contributor

@MattKear MattKear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattKear
Copy link
Contributor

Just Spoken with @bnsgeyer. He is unavailable to make the call this evening so has requested that we post-pone this PR until next week.

Copy link
Contributor

@bnsgeyer bnsgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmackay9 rmackay9 merged commit b8114da into ArduPilot:master Dec 5, 2023
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants