Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Periph: Serial Lights ID Support #25607

Closed
wants to merge 0 commits into from
Closed

AP_Periph: Serial Lights ID Support #25607

wants to merge 0 commits into from

Conversation

davidbitton
Copy link
Contributor

AP_Periph (and SerialLED.h/.cpp) are updated to propagate the light_id from a LightsCommand to NeoPixel.

magicrub
magicrub reviewed Nov 22, 2023
View reviewed changes
Tools/AP_Periph/can.cpp Outdated Show resolved Hide resolved
magicrub
magicrub requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@magicrub magicrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some squashing and better commit names. Merge commits are not allowed, rebase instead. Check the style guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbittonmbp davidbittonmbp davidbittonmbp left review comments

@magicrub magicrub magicrub requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidbitton @magicrub @davidbittonmbp