Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Generator: Intelligent Energy: add support for new protocol version #25616

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

IamPete1
Copy link
Member

@IamPete1 IamPete1 commented Nov 23, 2023

This adds support for a new protocol version that will be used by Intelligent Energy fuel cells going forward. The protocol version is auto-detected, core functionality is the same but we get better error messages and more information about the hardware and software version running on the fuel cell. It also adds a checksum to give some protection against data corruption.

This also adds the new protocol version to our simulator and autotest.

This is already hidden AP_GENERATOR_IE_2400_ENABLED define, which is currently enabled on 2M boards.

This has been flight tested by the folks at intelligent energy.

@IamPete1 IamPete1 requested a review from peterbarker November 23, 2023 01:52
@YasinMh
Copy link

YasinMh commented Nov 23, 2023

Tested on copter running 4.4.2 on Cube Orange+, with IE-Soar 2.4kW. Ground tests include generating various errors on the fuel cell and confirming correct error shows on GCS + correct battery failsafe (low/critical) is triggered. Confirmed generator states and unhealthy messages appear as expected. Conducted flight tests without issue.

@tridge tridge merged commit d626928 into ArduPilot:master Nov 28, 2023
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants