AP_Scripting: simplify Rover quick tune #25629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is only effecting a script and it's md so it's low risk. I say we YOLO merge it |
magicrub
approved these changes
Nov 26, 2023
|
@rmackay9 |
tridge
approved these changes
Nov 29, 2023
tridge
previously requested changes
Nov 29, 2023
Only tunes FF. P and I are set as ratio to FF
rmackay9
force-pushed
the
rover-quiktune-simple
branch
from
a92197a to
4bbc813
Compare
|
This is included in Copter-4.4.4-beta1 and Rover-4.4.0-beta11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the Rover quiktune so that it only tunes the Steering (aka Turn rate) and Speed controller feed-forward values. It then simply sets the corresponding P and I values to configurable ratios of the feed-forward.
While the rover tune received initial positive feedback, over time it became clear that the gains it produced were always too high and to get them into a reasonable range we had to set the backoff margin to ridiculously high values like 90% at which point it became very questionable as to whether the raise-gains-until-it-oscillates method is appropriate for rovers and boats.
This has been successfully tested in SITL and on a real vehicle.
This resolves issue #24729
The testing discussion is here.