-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Motors:expand heli tail param metadata #25635
Conversation
Just Spoken with @bnsgeyer. He is unavailable to make the call this evening so has requested that we post-pone this PR until next week. |
a724b22
to
0e4514b
Compare
I think its correct now... |
okay....really correct now...I think...matches new wiki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hwurzburg I provided a suggestion for the Tail Type Description. Hopefully that makes things clearer.
@Gone4Dirt If you approve this. I will merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two changes I requested have not been done but have been marked resolved.
I would like for the external gyro metadata to be clearly marked as Motor 7 function to start getting away from confusion in heli between RC out channels and motors functions as we are no longer hard coded to channel outputs.
@Gone4Dirt good catch! I had made the changes...on my laptop, but did not push them...then made Bill's changes on my desktop...anyway...pushed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing that @Hwurzburg.
thanks! |
NFC, as I was updating heli tail stuff for yaw trim add,I found this info lacking in metadata that would help users setting up