Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Motors:expand heli tail param metadata #25635

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

Hwurzburg
Copy link
Collaborator

NFC, as I was updating heli tail stuff for yaw trim add,I found this info lacking in metadata that would help users setting up

@MattKear
Copy link
Contributor

Just Spoken with @bnsgeyer. He is unavailable to make the call this evening so has requested that we post-pone this PR until next week.

@Hwurzburg Hwurzburg force-pushed the ddvp branch 2 times, most recently from a724b22 to 0e4514b Compare December 7, 2023 13:22
@Hwurzburg
Copy link
Collaborator Author

I think its correct now...

@Hwurzburg
Copy link
Collaborator Author

okay....really correct now...I think...matches new wiki

Copy link
Contributor

@bnsgeyer bnsgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hwurzburg I provided a suggestion for the Tail Type Description. Hopefully that makes things clearer.

@bnsgeyer
Copy link
Contributor

@Gone4Dirt If you approve this. I will merge it.
Thanks!

Copy link
Contributor

@MattKear MattKear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two changes I requested have not been done but have been marked resolved.
I would like for the external gyro metadata to be clearly marked as Motor 7 function to start getting away from confusion in heli between RC out channels and motors functions as we are no longer hard coded to channel outputs.

@Hwurzburg
Copy link
Collaborator Author

@Gone4Dirt good catch! I had made the changes...on my laptop, but did not push them...then made Bill's changes on my desktop...anyway...pushed now

Copy link
Contributor

@MattKear MattKear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing that @Hwurzburg.

@bnsgeyer bnsgeyer merged commit 5c1ed96 into ArduPilot:master Dec 20, 2023
@Hwurzburg
Copy link
Collaborator Author

thanks!

@Hwurzburg Hwurzburg deleted the ddvp branch December 21, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants