Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rover: Circle mode aux function support and SYSID_MYGCS param desc fix #25636

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Nov 26, 2023

This PR adds Rover support for the existing Circle mode auxiliary function switch. Circle mode was added to Rover in PR #23890 back in may.

There are also these unrelated parameter description fixes that I noticed while making the above change:

  • Rover's PSC_VEL_I parameter range is updated to allow "0" which is actually the params default value.
  • SYSID_MYGCS parameter increment is set to "1" for all vehicles. This should fix MP's odd behaviour of making it easy to set the parameter to values like 254.9 (see below how this can happen)

image

These changes have been lightly tested in SITL.

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmackay9 rmackay9 merged commit befd601 into ArduPilot:master Nov 27, 2023
87 checks passed
@rmackay9
Copy link
Contributor Author

Based on @IamPete1's approval I'm going to merge this and save some time on the dev call. Thanks!

@rmackay9 rmackay9 deleted the rover-nfc-changes branch November 27, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants