Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sum8 to sum8_with_carry #25663

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

peterbarker
Copy link
Contributor

@Ryanf55 pointed out that "sum8" should be reserved for sum-bytes-modulus-256 only as that's the common name for that algorithm.

Board               AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       *      *           *       *                 *      *      *
HerePro             *                                                                     
Hitec-Airspeed      *                                                                     
KakuteH7-bdshot                *      *           *       *                 *      *      *
MatekF405                      *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot             *                  *       *                 *      *      *
f103-QiotekPeriph   *                                                                     
f303-Universal      *                                                                     
iomcu                                                           *                         
revo-mini                      *      *           *       *                 *      *      *
skyviper-v2450                                    *                                       

the name "sum8" is usually used for "sum all bytes into a uint8_t discarding carry"
the name "sum8" is usually used for "sum all bytes into a uint8_t discarding carry"
@peterbarker peterbarker merged commit 4ede307 into ArduPilot:master Nov 29, 2023
87 checks passed
@peterbarker peterbarker deleted the pr/rename-sum8 branch November 29, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants