Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Mount: added sending of position and velocity to Siyi #25736

Closed
wants to merge 2 commits into from

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Dec 8, 2023

This will allow for exif tags in photos with position of aircraft

@tridge tridge added the Gimbal label Dec 8, 2023
@tridge tridge requested a review from rmackay9 December 8, 2023 21:02
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on a Siyi A8 running the latest Siyi firmware (0.3.4) and it seems fine.

tridge added 2 commits June 26, 2024 18:30
this is easy to get wrong
this will allow for exif tags of position for photos
@rmackay9
Copy link
Contributor

I will test that the EXIF works on an A8

@rmackay9
Copy link
Contributor

rmackay9 commented Jun 27, 2024

@tridge,

I tested with the SiyiA8 running the latest gimbal and camera firmwares (0.3.7 and 0.2.6 respectively) and while it all seems to basically work (e.g the gimbal moves, pictures and videos are recorded), the EXIF does not include the vehicle's location
image

@rmackay9
Copy link
Contributor

rmackay9 commented Jul 1, 2024

I've taken the devCall tag off of this one because we've since had a discussion with Siyi and there have been some changes to their API.

@rmackay9
Copy link
Contributor

rmackay9 commented Jul 4, 2024

Hi @tridge,

Could you replace the contents of the PR with the last commit from this branch? https://github.com/rmackay9/rmackay9-ardupilot/commits/tridge-siyi-position/

The code in this PR fails to send the location because it exceeds the maximum packet length. With this fix, I've confirmed that the A8 does store the correct location into the images (aka EXIF)

There appears to be an issue on the Siyi side with the altitude appearing as "Below" Sea Level but hopefully that can be resolved on their side.

@rmackay9
Copy link
Contributor

rmackay9 commented Jul 5, 2024

Let's close this in favour of #27457

@rmackay9 rmackay9 closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants