-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Mount: added sending of position and velocity to Siyi #25736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on a Siyi A8 running the latest Siyi firmware (0.3.4) and it seems fine.
this is easy to get wrong
this will allow for exif tags of position for photos
I will test that the EXIF works on an A8 |
I've taken the devCall tag off of this one because we've since had a discussion with Siyi and there have been some changes to their API. |
Hi @tridge, Could you replace the contents of the PR with the last commit from this branch? https://github.com/rmackay9/rmackay9-ardupilot/commits/tridge-siyi-position/ The code in this PR fails to send the location because it exceeds the maximum packet length. With this fix, I've confirmed that the A8 does store the correct location into the images (aka EXIF) There appears to be an issue on the Siyi side with the altitude appearing as "Below" Sea Level but hopefully that can be resolved on their side. |
Let's close this in favour of #27457 |
This will allow for exif tags in photos with position of aircraft