Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IOMCU analog readings #25739

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix IOMCU analog readings #25739

merged 2 commits into from
Dec 11, 2023

Conversation

andyp1per
Copy link
Collaborator

@andyp1per andyp1per commented Dec 9, 2023 •
edited
Loading

ADC readings on iomcu were broken by the dshot work. This fixes them.

@andyp1per andyp1per added the BUG label Dec 9, 2023
@tridge
Copy link
Contributor

tridge commented Dec 11, 2023

@andyp1per what testing has been done?

@andyp1per
Copy link
Collaborator Author

Bench tested on a CubeOrange.

@tridge
Copy link
Contributor

tridge commented Dec 11, 2023

Bench tested on a CubeOrange.

just for zero voltage, or for some known voltage?

@andyp1per
Copy link
Collaborator Author

For a known voltage:

image

This is also just a backport of the code that I extensively tested earlier

@tridge tridge merged commit 4a48dc2 into ArduPilot:master Dec 11, 2023
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

Assignees
No one assigned
Labels
BUG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyp1per @tridge