Detect board class by inheritance instead of naming #25740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
approved these changes
Apr 5, 2024
|
I've fixed up the commit message to conform to our standards. I don't know if the method was really worth it (it doesn't really scan as good English), but this is a definite improvement. Thanks, will MergeOnCIPass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all (actually none?) Linux boards have
linuxin their names, but the task detection logic only checks that, resulting in Linux boards being misclassified. In practical terms this means they also pull the unnecessary bootloader in, but overall this makes the clause misleading.This PR adds functionality to detect the base class of the board by probing inheritance and thus fixes this.