Plane: allow takeoff setting expected in manual and move landing override up #25745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One functional change to allow take off expected to be set in manual. This will only happen if not flying armed and either high throttle or a throw is detected.
Mode enter now updates flight stage. This would usually happen at 10Hz in the
update_altcall or insetup_glide_slopewhich RTL already calls as part of its enter.With the flight stage race removed we can be sure that we will never be in
FlightStage::LANDin manual mode. This means the landing servo override can be moved up with no change in behavior.I have also renamed
set_servos_controlledtoset_throttle.