Plane:fix auto fence enable in Mode Takeoff #25788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Dec 18, 2023
Hwurzburg
force-pushed
the
mode_takeoff_fix
branch
from
7efde12 to
cd77276
Compare
yes...same issue with auto mode fw and vtol takeoffs....just the same pattern....violating a fence on a planned takeoff is a user config error....one that becomes immediately obvious |
joshanne
suggested changes
Dec 19, 2023
| #if AP_FENCE_ENABLED | ||
| void ModeTakeoff::_exit() | ||
| { | ||
| if (plane.is_flying() && plane.is_flying()) { |
There was a problem hiding this comment.
Checking the plane is definitely flying?
|
closed , replaced with #25804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug in Mode takeoff where autoenable occurs immediately after initial phase of climb and triggers min alt fence breach....AUTO takeoffs (both fw and VTOL) do not auto-enable until takeoff alt is obtained and mission moves to next item....this does roughly the equivalent
addresses #25783