Support GPS_RAW_DATA for PX1 GNSS resolve #25517 #26042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanf55
reviewed
Jan 22, 2024
|
@Ryanf55 Please review the latest changes, considering the feedback you provided earlier. I've implemented adjustments similar to what has been done in both AP_GPS_Ublox.cpp and AP_GPS_SBF.cpp, as seen here: link. The current logic assumes logging is enabled when the _raw_data parameter is non-zero. Additionally, if _raw_data is set to 2, logging is disabled upon disarming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure of how I handled
gsofmsg_timeand disarming. Please do review the same. Thank you.