-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend use of AP_BATTERY_ENABLED #26106
Conversation
14c5ba0
to
ed03889
Compare
Nice and modular, but what is the use case? |
Sid brought a PR to DevCall tonight which had to play games in the AP_Notify library because.... AP_Periph which can have a Notify device but not a battery monitor. There are definitely many libraries we don't want on Periph (motors!), but I figured may as well get things working with our current boards. This doesn't allow you to build anything but peripherals with the define disabled (AFAIK)! It also helps point out where things should be grouped a bit, I think. My goal with this PR is no-compiler-output-change-except-on-Periph-where-it-stops-nullptr-dereference |
these have no effect
ed03889
to
cb45439
Compare
|
No description provided.