Mount: Siyi waits for non-zero cam firmware version #26168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtuxworth
reviewed
Feb 8, 2024
| _fw_version.gimbal.major = _msg_buff[_msg_buff_data_start+6]; // firmware major version | ||
| _fw_version.gimbal.minor = _msg_buff[_msg_buff_data_start+5]; // firmware minor version | ||
| _fw_version.gimbal.patch = _msg_buff[_msg_buff_data_start+4]; // firmware revision (aka patch) | ||
|
|
||
|
|
There was a problem hiding this comment.
Should there be a timeout on this? What if there is a problem and the camera keeps reporting 0.0.0, perhaps the user needs to know that? This will just wait and wait right?
There was a problem hiding this comment.
Yes, that's the downside I mention in the PR description above. I'm not aware of any Siyi cameras that ever do this though so I'm not sure if it is worth the extra code to protect against this.
|
I compiled this into a local copy of Plane 4.5.0 beta 1 and can confirm that it now reports the correct camera version! |
|
Merged, thanks! Also marked to make sure it gets into 4.5 |
92 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Siyi A8 (at least) will report an all-zero camera firmware version for the first 20seconds after startup. Assuming the gimbal and autopilot are powered up together this may or may not result in a warning sent to the user (see below):
This PR changes the Siyi mount driver so that it does not complete initialisation until a non-zero camera version is provided.
The only downside is Siyi gimbals that always report camera fw version of 0,0,0 will become unusable. I'm not aware of any Siyi gimbals that do this however.
This has been tested on real hardware.
Before:
After:
Related discussion is here.