Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Add prerequisites install script for openSUSE Tumbleweed #26210

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Jaaaky
Copy link
Contributor

@Jaaaky Jaaaky commented Feb 13, 2024

Tried to make it as complete as compatible as possible with Ubuntu environment

Installing static libs for SITL_static
And gcc_arm-linux for Linux based boards

@magicrub
Copy link
Contributor

Is tumbleweed a version of SUSE? If so, it shouldn't be in the filename but instead just be handled within the file for different versions

@Jaaaky Jaaaky force-pushed the openSUSE-TW-prereqs-installer branch from 9013d77 to 7ba2dcd Compare February 13, 2024 12:12
Copy link
Contributor

@magicrub magicrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling issue

@Jaaaky
Copy link
Contributor Author

Jaaaky commented Feb 13, 2024

Is tumbleweed a version of SUSE? If so, it shouldn't be in the filename but instead just be handled within the file for different versions

No it's actually a rolling release flavor - there are 3 major SUSE versions:

  1. SUSE Enterprise for commercial support and so on, think of it a RHEL
  2. openSUSE leap that's stable, new release every many months, think of it as ubuntu LTS
  3. openSUSE tumbleweed which is rolling release distribution where a new version is released every few days, much like Acrhlinux/Manjaro and so on.

So for leap handling it'd be another story where tracking of versions and so on would occur within the file itself much like with ubuntu script.

@Jaaaky
Copy link
Contributor Author

Jaaaky commented Feb 13, 2024

Minor spelling issue

Sorry, where is it? I cannot find your comment, maybe it has gone before the force-update?

@Jaaaky
Copy link
Contributor Author

Jaaaky commented Feb 15, 2024

@magicrub
This pr is ready for merge. I've tested on different setups including WSL installations.
ccache config is approved by @tridge

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some stuff we could factor out here somewhere? Looks like there's a chunk of stuff copied which could be shared.

I don't think it needs to be done here, but anything you share with other scripts is stuff which someone may else fix when it breaks...

@Jaaaky
Copy link
Contributor Author

Jaaaky commented Feb 16, 2024

@peterbarker
All done/fixed and re-tested.
Thank you
For other scripts specially for Ubuntu as it's more widely used and I do not personally use it, it's better to be modified by their maintainer.

Tried to make it as complete as compatible as possible with Ubuntu environment

Installing static libs for SITL_static
And gcc_arm-linux for Linux based boards
@peterbarker peterbarker force-pushed the openSUSE-TW-prereqs-installer branch from d8221a7 to 035e6a1 Compare February 16, 2024 14:13
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've squashed this into one commit and will mark it MergeOnCIPass

@peterbarker peterbarker merged commit 9986fb9 into ArduPilot:master Feb 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants