AP_Camera: fix video recording while armed #26217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
force-pushed
the
camera-arm-record-fix
branch
from
1a6d189 to
586a5ec
Compare
92 tasks
tridge
approved these changes
Feb 14, 2024
|
does the enum need NONE=0? like it was originally |
Randy is describing bits here - there's no "none" |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced by #25883 that meant the CAM1_OPTIONS's RecordWhileArmed option was not working.
This has been tested on real hardware (CubeOrangePlus + Xacti CX-CB100)
FYI @Hwurzburg (not saying it's all your fault of course, I reviewed and merged it and also didn't catch the issue).