AP_DroneCAN: DNA Server: log duplicate nodes in CAND #26224
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we get a CAND log of any duplicate nodes that turn up, this should make it much easier to track down what is going on. It still get the log even if ignore duplicates is set, its still valid to log because it better represents the peripherals connected. Logging is still only done if a log has been started, if the issue is a boot you would have to enable disarmed logging to get the original unique ID that caused the conflict.
Note that we only get 1 extra log, so if there are multiple duplicates we only get the first.
Tested by deliberately setting two static IDs to conflict. In this case the two devices were both here2's so only the UID is different, but the other fields would also be different for other devices.