Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_OAPathPlanner: using static constexpr instead const #26240

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

peterbarker
Copy link
Contributor

Extracted from d6a0fbe so we can discuss the meat of (and rename) that other PR properly.

@xianglunkai

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *                                       

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Feb 17, 2024

While switching from #define to static const makes sense for compile time size checks, what does this switch buy us?

@peterbarker
Copy link
Contributor Author

While switching from #define to static const makes sense for compile time size checks, what does this switch buy us?

Simplifies the other PR.

That's all I was after....

@peterbarker peterbarker merged commit 9123554 into ArduPilot:master Feb 19, 2024
92 checks passed
@peterbarker peterbarker deleted the pr/static-constexpr branch February 20, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants