Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadplane: fix Q_TRIM_PITCH description #26242

Merged
merged 1 commit into from
May 13, 2024

Conversation

robertlong13
Copy link
Collaborator

The description refers to TRIM_PITCH, which was recently renamed to
PTCH_TRIM_DEG.

@timtuxworth
Copy link
Contributor

I believe this is for the Q_TRIM_PITCH parameter, which is a different thing from the new PTCH_TRIM_DEG parameter which applies to a plane in fixed wing mode. This parameter was and is already in degrees.
I agree it's confusing, but the Q_ parameter wasn't changed. How about changing the name of the parameter too?

@robertlong13
Copy link
Collaborator Author

robertlong13 commented Feb 16, 2024

I believe this is for the Q_TRIM_PITCH parameter, which is a different thing from the new PTCH_TRIM_DEG parameter which applies to a plane in fixed wing mode. This parameter was and is already in degrees. I agree it's confusing, but the Q_ parameter wasn't changed. How about changing the name of the parameter too?

Yes, this is for the Q_TRIM_PITCH parameter, and it is different from PTCH_TRIM_DEG. But the part in the description that refers to "forward flight trim which includes TRIM_PITCH" is definitely referring to the old forward flight TRIM_PITCH parameter, not Q_TRIM_PITCH

I don't think we need to rename this parameter, we just need to fix the reference to the now-nonexistant parameter that it mentions in passing.

@robertlong13 robertlong13 changed the title Quadplane: fix TRIM_PITCH description Quadplane: fix Q_TRIM_PITCH description Feb 16, 2024
@timtuxworth
Copy link
Contributor

I see your point. That does actually clarify this then. Thanks Bob.

@tridge tridge merged commit 34704d3 into ArduPilot:master May 13, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4.5.5-beta1
Development

Successfully merging this pull request may close these issues.

5 participants