Add detected message when GPS found #26257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/probe-messages
branch
from
da6fe85 to
6f66be6
Compare
khancyr
approved these changes
Feb 19, 2024
| @@ -499,7 +499,7 @@ const AP_Param::GroupInfo SIM::var_gps[] = { | |||
| // @Param: GPS_TYPE | |||
| // @DisplayName: GPS 1 type | |||
| // @Description: Sets the type of simulation used for GPS 1 | |||
| // @Values: 0:None, 1:UBlox, 5:NMEA, 6:SBP, 7:File, 8:Nova, 9:SBP, 10:Trimble, 19:MSP | |||
| // @Values: 0:None, 1:UBlox, 5:NMEA, 6:SBP, 7:File, 8:Nova, 9:SBP2, 11:Trimble, 19:MSP | |||
There was a problem hiding this comment.
isn't trimble a SBF type ? so we that would be 10 ? @Ryanf55
There was a problem hiding this comment.
No, Trimble PX1 uses GSOF as a protocol and has no affiliation with SBF.
There was a problem hiding this comment.
Ok so some comment on ap_gps are misleading then as they said sbf and trimble are similar
peterbarker
force-pushed
the
pr/probe-messages
branch
from
6f66be6 to
fd8c449
Compare
tridge
requested changes
Feb 19, 2024
libraries/AP_GPS/AP_GPS.cpp
Outdated
|
|
||
| // we set delta_time_ms to the timeout value when clearing | ||
| // state; use it being zero to mark first message | ||
| if (timing[instance].delta_time_ms == GPS_TIMEOUT_MS) { |
There was a problem hiding this comment.
this seems odd - what stops delta_time_ms from being GPS_TIMEOUT_MS later in the flight?
maybe a "bool announced_gps" variable would be better?
peterbarker
force-pushed
the
pr/probe-messages
branch
from
fd8c449 to
0bae80c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master:
after this PR:
And the most common uBlox case where the thing got auto-configured:
