Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: QLAND if long failsafe on VTOL takeoff #26260

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Plane: QLAND if long failsafe on VTOL takeoff #26260

merged 1 commit into from
Feb 19, 2024

Conversation

CallanDaniel
Copy link
Contributor

For QuadPlanes utilizing the RTL_AUTOLAND functionality with DO_LAND_START points and the Q_RTL_MODE parameter set to 0, in order to use a mission-based landing approach:

Presently, if a LONG_FAILSAFE event is triggered during an automated VTOL takeoff, the aircraft will transition back to forward flight regardless of its current altitude, and continue to the waypoint subsequent to the DO_LAND_START command. This behavior presents a significant safety risk, especially for larger aircraft.

This change results in the aircraft entering QLAND mode if a LONG_FAILSAFE is triggered during a VTOL takeoff.

Tested in SITL.

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible.

ArduPlane/events.cpp Outdated Show resolved Hide resolved
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea. The only edge case I can think if is if your already flying and re-start the mission, in which case we will do the takeoff again but because its not a take off from the ground there is no guarantee that its OK to land at the current location. But we already dump into QLand in VTOL takeoff for timeout or high wind, so that issue exists already.

@tridge tridge merged commit a404693 into ArduPilot:master Feb 19, 2024
62 checks passed
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants