Nuke macOS warnings #26264
Merged
Nuke macOS warnings #26264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Feb 19, 2024
tridge
reviewed
Feb 20, 2024
| @@ -84,7 +84,7 @@ class AP_Filesystem { | |||
| int stat(const char *pathname, struct stat *stbuf); | |||
|
|
|||
| // stat variant for scripting | |||
| typedef struct { | |||
| typedef struct Stat { | |||
There was a problem hiding this comment.
curious, what warning is this for?
There was a problem hiding this comment.
../../libraries/AP_Filesystem/AP_Filesystem.h:87:19: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
typedef struct {
^
stat_t
../../libraries/AP_Filesystem/AP_Filesystem.h:93:9: note: type is not C-compatible due to this member declaration
bool is_directory(void) const {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../libraries/AP_Filesystem/AP_Filesystem.h:96:7: note: type is given name 'stat_t' for linkage purposes by this typedef declaration
} stat_t;
^
1 warning generated.
andyp1per
force-pushed
the
pr-mac-warnings
branch
from
d362ad8 to
b0f9fc5
Compare
|
This is included in 4.5.6-beta1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More macOS compile warnings to nuke