Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: Heli: rework inverted flight flags and ensure only in a supported mode. #26345

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

IamPete1
Copy link
Member

@IamPete1 IamPete1 commented Feb 28, 2024

This removes the inverted flight state in copter and motors and just keeps it in Attitude control. This then adds a new per mode allows_inverted which is false for everything except stabilize. This method allows checking that the current mode allows inverted before enabling it and it allows disabling inverted flight on mode exit if the new mode does not support it.

@IamPete1 IamPete1 requested a review from bnsgeyer February 28, 2024 04:18
@IamPete1 IamPete1 changed the title Copter: Heli: rework and ensure only in a supported mode. Copter: Heli: rework inverted flight flags and ensure only in a supported mode. Feb 28, 2024
@IamPete1 IamPete1 force-pushed the heli_inverted branch 2 times, most recently from a170665 to 1f7efca Compare February 29, 2024 23:32
@IamPete1
Copy link
Member Author

IamPete1 commented Mar 2, 2024

Now includes a improvement from @bnsgeyer that smooths the transition between normal and inverted flight. Because of that improvement and the stabilize only mode check it is safe to remove the pre-arm for the inverted switch being setup.

Copy link
Contributor

@bnsgeyer bnsgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmackay9 rmackay9 merged commit cbb47ed into ArduPilot:master Mar 5, 2024
89 checks passed
@bnsgeyer bnsgeyer added the WikiNeeded needs wiki update label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TradHeli WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants