Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS_MAVLink: allow FTP to be compiled out with build_options.py #26354

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Feb 29, 2024

pbarker@fx:~/rc/ardupilot(pr/ftp-out)$ ./Tools/scripts/size_compare_branches.py --board=CubeOrange --extra-hwdef-branch=/tmp/branch.hwdef --vehicle=plane --master=pr/ftp-out

yields

Board,plane
CubeOrange,-4696

Copy link
Contributor

@magicrub magicrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, except when you say CubeOrange,-4696 you obviously mean it doesn't change anything for any build as-is but if you DID remove it... right?

@peterbarker
Copy link
Contributor Author

Looks fine, except when you say CubeOrange,-4696 you obviously mean it doesn't change anything for any build as-is but if you DID remove it... right?

I'd stuffed up the markup in my initial comment showing the command-line used to generate the delta. Fixed the comment to show it.

@peterbarker
Copy link
Contributor Author

peterbarker commented Mar 2, 2024

No compiler output change by default:

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *                                       

@peterbarker peterbarker merged commit d6df142 into ArduPilot:master Mar 2, 2024
92 checks passed
@peterbarker peterbarker deleted the pr/ftp-out branch March 2, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants