Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub: fix several EK3_MAG_Fusion cases for Sub #26394

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

clydemcqueen
Copy link
Contributor

@clydemcqueen clydemcqueen commented Mar 4, 2024

Fix several EK3_MAG_CAL cases for sub by flipping signs:

  • EK3_MAG_CAL,3 (AFTER_FIRST_CLIMB): look for -2.5m altitude change (vs +2.5m)
  • EK3_MAG_CAL,0 (WHEN_FLYING): look for -1.5m altitude change (vs +1.5m) or -0.5m rangefinder change (vs +0.5)

This might help a little with #18229.

[I edited this comment to match the latest code, and deleted older comments.]

@clydemcqueen clydemcqueen marked this pull request as draft March 5, 2024 00:46
@Williangalvani Williangalvani added this to the Sub-4.5 milestone Mar 5, 2024
@clydemcqueen clydemcqueen force-pushed the clyde_yaw_drift branch 2 times, most recently from f970330 to a94ebae Compare April 11, 2024 16:28
@clydemcqueen clydemcqueen changed the title Sub: request final yaw reset after diving 2.5m Sub: fix several EK3_MAG_CAL cases Apr 11, 2024
@clydemcqueen clydemcqueen marked this pull request as ready for review April 11, 2024 17:09
@Williangalvani Williangalvani changed the title Sub: fix several EK3_MAG_CAL cases Sub: fix several EK3_MAG_Fusion cases for Sub Jun 24, 2024
@tridge
Copy link
Contributor

tridge commented Jun 24, 2024

once commit msgs fixed to be "AP_NavEKF3: xxx" then can be merged, should be single commit

on sub, request final yaw reset after diving 0.5m.
Also update rangefinder tests for sub
@peterbarker peterbarker merged commit 0e6543f into ArduPilot:master Jun 25, 2024
92 checks passed
@clydemcqueen clydemcqueen deleted the clyde_yaw_drift branch June 25, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants