MissionItemProtocol_Rally: Use *_INT frames for Rally mission items #26400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
requested changes
Mar 5, 2024
| @@ -117,24 +117,24 @@ bool MissionItemProtocol_Rally::get_item_as_mission_item(uint16_t seq, | |||
| } | |||
|
|
|||
| // Default to relative to home | |||
| ret_packet.frame = MAV_FRAME_GLOBAL_RELATIVE_ALT; | |||
| ret_packet.frame = MAV_FRAME_GLOBAL_RELATIVE_ALT_INT; | |||
There was a problem hiding this comment.
We do not distinguish these frames.
i.e. An altitude frame doesn't care whether you're transporting things via integer or float.
The creation of these frames is acknowledged as a mistake.
|
The current behavior is inline with what we do for the mission and fence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_item_as_mission_item()returns amavlink_mission_item_int_tand as such should be using the*_INTversions of theMAV_FRAMEs.Follows from changes in #25380.
FYI: @IamPete1