Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Proximity: add RPLidarC1 support #26484

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Mar 11, 2024

This adds support for the RPLidar C1 based on development and discussion here.

The datasheet says the lidar has a "low blind range of 0.05m" so the 0.2m minimum is slightly conservative but consistent with other RPLidar.

@amilcarlucas
Copy link
Contributor

amilcarlucas commented Mar 11, 2024

We should point users that want to add support for new RPlidar models to this PR!

Binary Name      Text [B]       Data [B]     BSS (B)        Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  -------------  -----------  -------------  ----------------------------  -------------------------
arducopter       28 (+0.0016%)  0 (0.0000%)  -4 (-0.0015%)  28 (+0.0016%)                                    190284
arduplane        0 (0.0000%)    0 (0.0000%)  0 (0.0000%)    0 (0.0000%)                                      190956
antennatracker   0 (0.0000%)    0 (0.0000%)  0 (0.0000%)    0 (0.0000%)                                      642176
arducopter-heli  28 (+0.0016%)  0 (0.0000%)  -4 (-0.0015%)  28 (+0.0016%)                                    183852
ardurover        28 (+0.0017%)  0 (0.0000%)  -4 (-0.0015%)  28 (+0.0017%)                                    335168
ardusub          0 (0.0000%)    0 (0.0000%)  0 (0.0000%)    0 (0.0000%)                                      396268
blimp            0 (0.0000%)    0 (0.0000%)  0 (0.0000%)    0 (0.0000%)                                      619492

@rmackay9 rmackay9 added WikiNeeded needs wiki update DevCallTopic labels Mar 13, 2024
@rmackay9
Copy link
Contributor Author

We don't yet have confirmation that the change works but I've marked this for next week's dev call just so we don't forget about it.

@rmackay9
Copy link
Contributor Author

@rmackay9
Copy link
Contributor Author

I've rebased on master and adjusted the maximum to 12m to match the datasheet.

@tridge tridge merged commit c53f55f into ArduPilot:master Mar 20, 2024
91 checks passed
@rmackay9 rmackay9 deleted the rplidar-c1 branch March 25, 2024 00:30
@edykiro
Copy link

edykiro commented Sep 4, 2024

Hello everyone,
I'm using a RPLIDAR C1 with a Pixhawk 2.4.8. I'm having serious issues with the ACRO mode. When the LiDar is working, ACRO mode is out of control, inputting random throttle directives. When ACRO mode is working, the LiDar doesen't work properly. By tuning SCHED_LOOP_RATE, we've managed to either make the LiDar work properly, or Acro mode. But when one works, the other stops operating properly. This has been observed when modifying SCHED_LOOP_RATE from 50 Hz through 400 Hz. I'm wondering if anyone has gotten this issue, any extra data needed will be provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 4.5.0-beta4
Development

Successfully merging this pull request may close these issues.

6 participants