Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AP_GenericVehicle #26511

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

A "normal" AP_Vehicle, but with no "flight" logic.

@@ -1852,7 +1852,7 @@ def write_UART_config(self, f):
f.write('#define HAL_SERIAL%s_DRIVER Empty::UARTDriver serial%sDriver\n' %
(idx, idx))

if 'IOMCU_UART' in self.config:
if 'IOMCU_UART' in self.config and False:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this just make it never be true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this just make it never be true?

Yep! IOMCU is currently not working :-) Like a lot of things ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant, wouldn't this break other vehicles too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not get the point of this. I will ask you about this on a Dev meeting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant, wouldn't this break other vehicles too?

Oh yes, very thoroughly. This is an interim commit while I work out what to do about IOMCU. It wasn't a problem on boards other than Pixhawk6X that I was using, because no IOMCU.

Need to be able to be able to make a derivative board from a hwdef, removing the IOMCU. That's not really possible at the moment because IOMCU is a basic directive you can put into a hwdef and can't undo by something which is including that hwdef. Possibly by making AP_IOMCU_ENABLED actually work.... Don't know, I was in hack-and-slash mode for that bit as I wanted to get a hardware debugger in there, and had Pixhawk6X on my desk for that :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now found a better way to get this effect, so removed this hack. It did its job :-)

@peterbarker peterbarker force-pushed the pr/ap_custom branch 2 times, most recently from be70309 to ac05e30 Compare March 16, 2024 07:25
makes life difficult if you *do* want to supply your own fwversion object sometimes
... hopefully we can get rid of this method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants