Fixes and updates for CubePilot PPPGW #26512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bugobliterator
commented
Mar 14, 2024
bugobliterator
commented
- adds webui for vehicle build.
- adds PPP support to CubeOrangePlus
- changes for updated CubePilot PPPGW module
- fix broken webui trying to remove already closed socket
tridge
requested changes
Mar 14, 2024
tridge
force-pushed
the
pr-cubepilot-pppgw
branch
from
259a7c4 to
95dddd6
Compare
bugobliterator
force-pushed
the
pr-cubepilot-pppgw
branch
from
3f48b66 to
d94318f
Compare
bugobliterator
force-pushed
the
pr-cubepilot-pppgw
branch
3 times, most recently
from
e016957 to
2111385
Compare
bugobliterator
force-pushed
the
pr-cubepilot-pppgw
branch
from
2111385 to
496602d
Compare
bugobliterator
force-pushed
the
pr-cubepilot-pppgw
branch
from
496602d to
aa9f5de
Compare
peterbarker
reviewed
Jun 19, 2024
libraries/AP_HAL/utility/Socket.cpp
Outdated
| @@ -327,8 +347,12 @@ ssize_t SOCKET_CLASS_NAME::recv(void *buf, size_t size, uint32_t timeout_ms) | |||
| socklen_t len = sizeof(struct sockaddr_in); | |||
| int fin = get_read_fd(); | |||
| ssize_t ret; | |||
| ret = CALL_PREFIX(recvfrom)(fin, buf, size, MSG_DONTWAIT, (sockaddr *)&last_in_addr[0], &len); | |||
| if (ret <= 0) { | |||
| uint32_t in_addr[4] = {}; | |||
There was a problem hiding this comment.
Suggested change
| uint32_t in_addr[4] = {}; | |
| uint32_t in_addr[4] {}; |
tridge
force-pushed
the
pr-cubepilot-pppgw
branch
from
aa9f5de to
cfbbbf4
Compare
|
@bugobliterator I have rebased and fixed conflicts |
tridge
requested changes
Jun 21, 2024
bugobliterator
force-pushed
the
pr-cubepilot-pppgw
branch
from
cfbbbf4 to
389932a
Compare
TCP to an echo server, testing bi-directional transfer
allows for mcu temp
bugobliterator
force-pushed
the
pr-cubepilot-pppgw
branch
from
389932a to
137dc97
Compare
tridge
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.