-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwdef: new target CSKY405 #26523
hwdef: new target CSKY405 #26523
Conversation
The commit messages need to follow our code contribution guide. I can fix if you want me to |
It would be very nice if you did that |
needs a readme following the format an content of one like this https://github.com/ArduPilot/ardupilot/tree/master/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405WING |
@tridge @Hwurzburg I have corrected all your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit structure needs squash and library split
|
||
## PWM Output | ||
|
||
The CSKY405 supports up to 10 PWM outputs. S1-S4 outputs support DShot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have defined pwm1-4as bidir, but do not advertize this, which is good, because they share dma, it might not work. @andyp1per pls review and comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I will remove it in this PR and add it in the future when I check if this PR is accepted
|
||
## Overview | ||
|
||
![CSKY405](CSKY405.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link is not functional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, in Visual Studio Code, this link works, how else can I check it?
|
||
## Wiring Diagram | ||
|
||
![CSKY405 Wiring](CSKY405_wiring.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rchange russian labels to english
|
||
## RC Input | ||
|
||
RC input is configured on the SBUS pin (inverted and sent to UART2_RX). It supports all RC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cant seem to find the SBUS pin on picture...and your wiring diagram show an SBUS Receivers tied to RX2 which does not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is really no marking of the SBUS pin, instead there is an RX2 to which an S BUS can be connected (STM32F405 can invert this pin using the USART peripherals) and it works, also the RX2 pin can work like a regular USART
|
||
RC input is configured on the SBUS pin (inverted and sent to UART2_RX). It supports all RC | ||
protocols except serial protocols such as CRSF, ELRS, etc. Those devices can be connected to USART1 TX and RX, instead. | ||
Fport can be connected to USART1 TX also, but will require an external bi-directional inverter and the ref:`SERIAL1_OPTION<SERIAL1_OPTION>' = 4 (HalfDuplex) set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
USART1 is not SERIAL1
Co-authored-by: Henry Wurzburg <[email protected]>
Co-authored-by: Henry Wurzburg <[email protected]>
Co-authored-by: Henry Wurzburg <[email protected]>
Co-authored-by: Henry Wurzburg <[email protected]>
Co-authored-by: Henry Wurzburg <[email protected]>
Add CSKY405 FC update APJ_BOARD_ID readme update Add png image Update libraries/AP_HAL_ChibiOS/hwdef/CSKY405/Readme.md Co-authored-by: Henry Wurzburg <[email protected]> Update libraries/AP_HAL_ChibiOS/hwdef/CSKY405/Readme.md Co-authored-by: Henry Wurzburg <[email protected]> Update libraries/AP_HAL_ChibiOS/hwdef/CSKY405/Readme.md Co-authored-by: Henry Wurzburg <[email protected]> Update libraries/AP_HAL_ChibiOS/hwdef/CSKY405/Readme.md Co-authored-by: Henry Wurzburg <[email protected]> Update libraries/AP_HAL_ChibiOS/hwdef/CSKY405/Readme.md Co-authored-by: Henry Wurzburg <[email protected]> update board types
I couldn't merge the commits cleanly, because I was pulling up the actual changes between them. I'll just delete this RP and open a new one. |
Just add new flight controller CSKY405, @tridge please check it. The board IDs are updated faster than anyone can view this commit.