Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creating firmware version objects in GCS_Dummy #26545

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

This was always a bit of a nasty kludge, and gets in the way when you're trying to sometimes have a GCS in your firmware and sometimes not.

So instead of having the dummy do it, include a file into the cpp which accomplishes the same thing.

Only affects examples, unit tests and Replay.

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *                                       

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like making tests to be as easy as possible, and with each of these extra bits of bookkeeping requirements it makes it a bit harder. I'd prefer to move towards having less of this type of thing in every test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants