Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop passing serial manager to GPS init #26551

Merged
merged 11 commits into from
Mar 18, 2024
Merged

Stop passing serial manager to GPS init #26551

merged 11 commits into from
Mar 18, 2024

Conversation

peterbarker
Copy link
Contributor

it can get this via the singleton

@amilcarlucas
Copy link
Contributor 

Binary Name      Text [B]       Data [B]     BSS (B)       Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  -------------  -----------  ------------  ----------------------------  -------------------------
blimp            -4 (-0.0003%)  0 (0.0000%)  4 (+0.0015%)  -4 (-0.0003%)                                    618508
ardusub          -4 (-0.0003%)  0 (0.0000%)  4 (+0.0015%)  -4 (-0.0003%)                                    395228
antennatracker   -4 (-0.0003%)  0 (0.0000%)  4 (+0.0015%)  -4 (-0.0003%)                                    641736
ardurover        -4 (-0.0002%)  0 (0.0000%)  4 (+0.0015%)  -4 (-0.0002%)                                    334936
arducopter       0 (0.0000%)    0 (0.0000%)  0 (0.0000%)   0 (0.0000%)                                      189564
arducopter-heli  -4 (-0.0002%)  0 (0.0000%)  4 (+0.0015%)  -4 (-0.0002%)                                    183140
arduplane        0 (0.0000%)    0 (0.0000%)  0 (0.0000%)   0 (0.0000%)                                      190236

@peterbarker
AP_GPS: stop passing serial manager to GPS init
a3debda 
it can get this via the singleton
@peterbarker
AntennaTracker: stop passing serial manager to GPS init
285ba01 
it can get this via the singleton
@peterbarker
ArduCopter: stop passing serial manager to GPS init
f90d922 
it can get this via the singleton
@peterbarker
ArduPlane: stop passing serial manager to GPS init
6c854f8 
it can get this via the singleton
@peterbarker
ArduSub: stop passing serial manager to GPS init
626ed12 
it can get this via the singleton
@peterbarker
Blimp: stop passing serial manager to GPS init
c8f212f 
it can get this via the singleton
@peterbarker
Rover: stop passing serial manager to GPS init
3bb732a 
it can get this via the singleton
@peterbarker
AP_Module: stop passing serial manager to GPS init
33fb221 
it can get this via the singleton
@peterbarker peterbarker force-pushed the pr/gps-no-serialmanager branch from 8d7e2f7 to f58a400 Compare March 17, 2024 22:09
@peterbarker peterbarker force-pushed the pr/gps-no-serialmanager branch from f58a400 to 4ec04e1 Compare March 17, 2024 22:34
@tridge tridge merged commit 7e4d9f2 into ArduPilot:master Mar 18, 2024
91 checks passed
@peterbarker peterbarker deleted the pr/gps-no-serialmanager branch March 19, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

@IamPete1 IamPete1 IamPete1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterbarker @amilcarlucas @tridge @IamPete1 @CraigElder