-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Copter to compile when Fence is disable but Avoidance is not #26561
base: master
Are you sure you want to change the base?
Conversation
Thanks for this. This is a good idea but we should test in SITL that simple avoidance in Loiter mode works using only proximity sensors. |
I tested this and maybe I did something wrong but it seems like setting AP_FENCE_ENABLED definition to zero led to AC_Avoidance library disappearing. the AVOID_xxx parameters disappeared. This is the command line I used Just for reference, instructions for testing with proximity sensors in SITL are here: https://ardupilot.org/dev/docs/adding_simulated_devices.html#adding-a-360deg-lidar |
the technical reasons in Avoidance were fixed a long time ago
the technical reasons in Avoidance were fixed a long time ago
useful if you need to test multiple features at the same time
52d3efe
to
ccb5c3e
Compare
@@ -4,7 +4,7 @@ | |||
#include <AC_Fence/AC_Fence_config.h> | |||
|
|||
#ifndef AP_AVOIDANCE_ENABLED | |||
#define AP_AVOIDANCE_ENABLED AP_FENCE_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should change this so it's (AP_FENCE_ENABLE || HAL_PROXIMITY_ENABLED || AP_BEACON_ENABLED). No point in having avoidance if none of these are available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see if this works - but this sort of thing usually ends up with include loops / tears.
This arose out of a previous PR - #26466 IIRC.
There hasn't been a technical requirement for this for some time..
Also expanded the tool used to test this sort of change to
build_options.py
. The important ouputs were: