Plane: do not set desired vel/accel on takeoff for quadplanes #26573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
approved these changes
Mar 23, 2024
|
@IamPete1 we tested this today and are very happy with the results. before after |
This effectively bypasses the input shaping. Currently this creates a step change in the position controller.
|
I've rebased this on master to remove the merge commits. Marking this for DevCall based on @IamPete1 's positive review... |
tridge
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively bypasses the input shaping.
Currently this creates a step change in the position controller.
Removing this allows for the smooth setting.
