Tools: extract_param_defaults can now also extract 'values' and 'non_… #26579
+107
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amilcarlucas
force-pushed
the
pr-extract-non-default-params
branch
from
c900b1b to
aea2f8d
Compare
peterbarker
reviewed
Mar 21, 2024
| if hasattr(m, 'Value') and hasattr(m, 'Default') and m.Value != m.Default: | ||
| values[pname] = m.Value | ||
| else: | ||
| raise SystemExit("Invalid type %s" % type) |
There was a problem hiding this comment.
I plan to exit and not have a cryptic backtrace
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| import unittest | |||
| from unittest.mock import patch, MagicMock | |||
| from extract_param_defaults import extract_parameter_default_values, missionplanner_sort, \ | |||
| from extract_param_defaults import extract_parameter_values, missionplanner_sort, \ | |||
There was a problem hiding this comment.
Presumably we're missing a test for this new functionality here...
There was a problem hiding this comment.
Yes, I did not add any new tests for the new functionality yet.
| @@ -71,7 +71,7 @@ def test_logfile_does_not_exist(self, mock_mavlink_connection): | |||
|
|
|||
| # Call the function with a dummy logfile path | |||
| with self.assertRaises(SystemExit) as cm: | |||
| extract_parameter_default_values('dummy.bin') | |||
| extract_parameter_values('dummy.bin') | |||
There was a problem hiding this comment.
This is awkward. You haven't added the keyword argument here, so this doesn't actually get the parameter values, does it? It gets the default values?
Might I suggest adding an entry point to the library instead?
So leave extract_parameter_default_values and add extract_parameter_valuesas a separate call.
There was a problem hiding this comment.
The default is to test default values
amilcarlucas
force-pushed
the
pr-extract-non-default-params
branch
from
aea2f8d to
13b1fd5
Compare
…default_values' Also rename a bit to make it more generic
amilcarlucas
force-pushed
the
pr-extract-non-default-params
branch
from
ef1ddb6 to
c7f6357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…default_values'
Also rename a bit to make it more generic