Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwdef: remove save_some_flash.inc #26599

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

peterbarker
Copy link
Contributor

all but one board was getting all of these includes from minimize_fpv_osd, and the remaining board had most lines foming from minimize_features.inc.

This file has served its purpose, its role now taken on by minimize_fpv_osd.inc

all but one board was getting all of these includes from minimize_fpv_osd, and the remaining board had most lines foming from minimize_features.inc.

This file has served its purpose, its role now taken on by minimize_fpv_osd.inc
@peterbarker
Copy link
Contributor Author

I've run this through size_compare_branches.py and the only builds changed are:

pbarker@threads:~/rc/ardupilot$ ~/rc/ardupilot/Tools/scripts/filter_size_compare_branches_csv.py /tmp/some.csv  --hide-bin 
------------------------  -----  ------  ----  -----  -----  ---
Board                     blimp  copter  heli  plane  rover  sub
SITL_arm_linux_gnueabihf  0      0       0     0      0      0
SITL_x86_64_linux_gnu     0      0       0     0      0      0
------------------------  -----  ------  ----  -----  -----  ---
pbarker@threads:~/rc/ardupilot$ 

... we really should try to make those ones binary-identical for any change which should produce the same binaries at some stage...

@peterbarker peterbarker merged commit 813f0cf into ArduPilot:master Mar 24, 2024
40 checks passed
@peterbarker peterbarker deleted the pr/remove-save-some-flash branch March 25, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants