Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL: Fix incorrect return type for 64 bit float pointer conversion for MicroStrain7 #26603

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Mar 24, 2024

  • This caused position quantization errors in the MicroStrain7 converting the double
  • This function is currently only used in the MicroStrain7 driver
  • This should be backported to 4.5, it was a bug.

image

* This caused position quantization errors in the MicroStrain7

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55 Ryanf55 added BUG For-4.5 Planned for 4.5 release labels Mar 24, 2024
@Ryanf55 Ryanf55 changed the title AP_HAL: Fix incorrect return type AP_HAL: Fix incorrect return type for 64 bit float pointer conversion Mar 24, 2024
@Ryanf55 Ryanf55 changed the title AP_HAL: Fix incorrect return type for 64 bit float pointer conversion AP_HAL: Fix incorrect return type for 64 bit float pointer conversion for MicroStrain7 Mar 24, 2024
@tridge tridge merged commit 650db2d into ArduPilot:master Mar 24, 2024
91 checks passed
@Ryanf55 Ryanf55 deleted the fix-narrowing-error-on-return branch March 24, 2024 21:14
@rmackay9
Copy link
Contributor

This is included in 4.5.2-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG For-4.5 Planned for 4.5 release MergeOnCIPass
Projects
Status: 4.5.2-beta1
Development

Successfully merging this pull request may close these issues.

3 participants