Periph: Enable use of multiple rangefinders #26607
Merged
+155
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKear
commented
Mar 24, 2024
tridge
requested changes
Mar 27, 2024
tridge
requested changes
Mar 27, 2024
MattKear
force-pushed
the
periph_multi_rngfnd
branch
from
386205b to
6fe2468
Compare
|
Made requested changes. Re-tested with L431 Node on the the bench. Have not been able to test that prob continuous works because my node and rangefinders are all powered off of the same supply. |
tridge
requested changes
Apr 3, 2024
MattKear
force-pushed
the
periph_multi_rngfnd
branch
2 times, most recently
from
c6ada89 to
9d6a471
Compare
MattKear
force-pushed
the
periph_multi_rngfnd
branch
from
9d6a471 to
a2d4aae
Compare
tridge
requested changes
Apr 10, 2024
MattKear
force-pushed
the
periph_multi_rngfnd
branch
from
a2d4aae to
741f98c
Compare
IamPete1
reviewed
Apr 10, 2024
MattKear
force-pushed
the
periph_multi_rngfnd
branch
3 times, most recently
from
cb34273 to
21b735e
Compare
tridge
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for up to two rangefinders on one CAN node.
I have only added support two instances on the Matek L431 nodes as I do not have other types to test.
Just for context, this is how I am using this change. I have a LiDaR and Radar both connected to the same L431 CAN node making integration of these into my heli, for height above ground measurement, nice and easy.
Tested IRL. RFND[0] is the radar and FRND[1] is the LiDaR
