Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Logger: Write_VER keep g++ 7.5 happy by removeing non-trivial designated initializers #26641

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

IamPete1
Copy link
Member

Same problem as #25362:

../../libraries/AP_Logger/AP_Logger_Backend.cpp: In member function ‘bool AP_Logger_Backend::Write_VER()’:
../../libraries/AP_Logger/AP_Logger_Backend.cpp:579:5: sorry, unimplemented: non-trivial designated initializers not supported
     };
     ^

This keeps g++ 7.5 working for now, at some point I guess we might want say we don't support it anymore.

@khancyr
Copy link
Contributor

khancyr commented Mar 28, 2024

I think we already don't support it as we need gcc10 to make the firmware fit into the small boards

@peterbarker
Copy link
Contributor

As @khancyr points out, we require >= 10.2 on our ChibiOS boards.

... I think the question is, "what's the default compiler on Ubuntu 20.04?"

We no longer need to support Ubuntu 18.04, so if the default on Ubuntu 20.04 supports the existing syntax I suggest we add a block similar to https://github.com/ardupilot/ardupilot/blob/master/Tools/ardupilotwaf/boards.py#L1154 into class Linux, class SITL and class ESP32....

@peterbarker
Copy link
Contributor

... if we decide instead to accept this PR, let's put a comment in place or this is going to keep happening :-)

@tridge tridge merged commit b080343 into ArduPilot:master Apr 2, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants