Test: GPS off by numsats < 10 && hdop > 1.2 #26655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dimrix81, Can you clarify a bit more what the issue is that you're seeing? Are you saying that if the GPS has some satellites but its fix state is still not yet FIX_2D so to the user it appears as NO_GPS instead of NO_FIX? |
peterbarker
requested changes
Apr 4, 2024
| @@ -866,6 +866,10 @@ void AP_GPS::update_instance(uint8_t instance) | |||
| // we have an active driver for this instance | |||
| bool result = drivers[instance]->read(); | |||
| uint32_t tnow = AP_HAL::millis(); | |||
|
|
|||
| if ((state[instance].num_sats < 10) && (state[instance].hdop > 120)) { | |||
There was a problem hiding this comment.
This doesn't look right. If you want to add quality measures like this then they belong elsewhere in the code (and they do exist elsewhere in the code).
Modifying the fix type just because you don't like some aspect of the fix isn't correct IMO, and will lead to unexpected behavioural changes where e.g. we use the time from the satellites even when we're not using the co-ordinates.
|
We haven't heard any reply so maybe I'll go ahead and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a task make NO_GPS, but this state (NO_FIX) is more logical: GPS is available, but not enough