Tools, CI: use same-bdshotness boards for ccache test #26714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ccache test uses two pairs of boards:
Matek-F405vsMatek-F405-bdshot, andPixhawk6XvsDurandal.With more code coming that depends on bidirectional DShot, these boards will increasingly diverge, causing the test to fail. My work-in-progress PR #26321 is one of such changes. In light of this, the choice of boards different by being or not being bdshot-enabled seems imperfect.
This PR updates the configuration of the ccache test, so that both pairs of boards have bdshot code enabled. I tried to change as little as possible, so the first pair becomes
Matek-F405-bdshotvsMatek-F405-TE-bdshot, and the second pair becomesPixhawk6XvsDurandal-bdshot. Note thatPixhawk6X, just likePixhawk6X-bdshot, is bdshot-enabled in terms of code compilation, because it has to support possible bidirectional DShot coming from IOMCUs.I updated the default arguments in the Python script as well to reduce possible confusion (if left unchanged, the default arguments will eventually stop producing a positive result).