Remove "far_from_EKF_origin" sanity checks #26727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some flawed implementations, and the extreme-ardupilot project means these checks are no longer required
rmackay9
reviewed
Apr 9, 2024
rmackay9
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
I think we can safely remove this check.
It mostly does almost no harm but I think it would cause problems if a boat was traveling far out to sea and was disarmed. I think it probably could not be re-armed without being rebooted.
EDIT: ah, but this check is not in Rover/Boat .. still, it's not necessary I think.
peterbarker
force-pushed
the
pr/remove-far-from-ekf-origin
branch
from
122b416 to
49ddeeb
Compare
some flawed implementations, and the extreme-ardupilot project means these checks are no longer required
some flawed implementations, and the extreme-ardupilot project means these checks are no longer required
peterbarker
force-pushed
the
pr/remove-far-from-ekf-origin
branch
from
49ddeeb to
8ff846d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @rmackay9 's comment, and my preference here: #26724