Lint hwdef include files #26736
Merged
Lint hwdef include files #26736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a linter script for hwdef files? |
|
I've run this through `size_compare_branches.py, rebased on top of patches to fix compilation of a couple of boards (and hwdef.dat include patch). Everything is no binary output-change. |
Sort of. There's code in There's a few additional patches past the ones in this PR which make things clean but they're a little more complicated than the ones included in this patch (and kind of show a hole up in the way we're trying to use includes in networking). |
peterbarker
force-pushed
the
pr/hwdef-include-linting
branch
from
7125d5a to
8be2ef0
Compare
tridge
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove a bunch of lines which are not needed