Correct back-to-back mission transfer with bad mission count #26804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NT.count we left things in the "receiving" state, which would eventually lead to a timeout, rather than just failing instanenously with the correct code.
peterbarker
force-pushed
the
pr/missionitemtransfer-fixes
branch
from
90fc0b9 to
48015ab
Compare
tridge
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that we reject the new packet for some reason the receiving status and link persisted.
This isn't fatal in that the upload-timeout will trigger, but it is messy in that we will end up sending back two acks - the one for the bad
MISSION_COUNT, and then the timeout later.