AP_Airspeed: ND210 pressure sensor, airspeed library #26859
Conversation
|
Hi @zzaurak, Thanks for this. Just a small admin thing, it would be good to change the commit title (not the PR title but the individual commit titles) to start with "AP_Airspeed: ". |
zzaurak
force-pushed
the
nd210-pressure-sensor
branch
from
8088a65 to
b78b8cc
Compare
|
Hi @rmackay9 thanks for the feedback, I changed the commit titles :) |
| @@ -71,3 +71,7 @@ | |||
| #ifndef AP_AIRSPEED_EXTERNAL_ENABLED | |||
| #define AP_AIRSPEED_EXTERNAL_ENABLED AP_AIRSPEED_ENABLED && HAL_EXTERNAL_AHRS_ENABLED | |||
| #endif | |||
|
|
|||
| #ifndef AP_AIRSPEED_ND210_ENABLED | |||
| #define AP_AIRSPEED_ND210_ENABLED AP_AIRSPEED_ENABLED | |||
There was a problem hiding this comment.
should this be changed to AP_AIRSPEED_BACKEND_DEFAULT_ENABLED instead of AP_AIRSPEED_ENABLED like it is in line 26 with the DLVR sensor? I don't really understand why there is this distinction, as they are both set to the same value in line 13.
zzaurak
changed the title
zzaurak
force-pushed
the
nd210-pressure-sensor
branch
3 times, most recently
from
4de9f82 to
a48f40e
Compare
|
As promised I did a real-world comparison test flight with the ND210 airspeed sensor and this PR. I've attached the log 00000028-anon.log.zip. ASPD[0] is the DLVR I would say pretty much comparable, but especially in the lower speed ranges and while in QLoiter and FBWA it looks a bit smoother. |
zzaurak
force-pushed
the
nd210-pressure-sensor
branch
from
a48f40e to
8ae6f35
Compare
|
@rmackay9 anything else that would be blocking a merge? |
zzaurak
force-pushed
the
nd210-pressure-sensor
branch
3 times, most recently
from
081fc23 to
5a380be
Compare
zzaurak
force-pushed
the
nd210-pressure-sensor
branch
from
5a380be to
a71dc45
Compare
adding ND210 Airspeed library Tuning ND210 refactored _send_configuration_command and renamed member variables Cleaning up printouts. Changing cast to uint.
& some fixes after rebase
zzaurak
force-pushed
the
nd210-pressure-sensor
branch
from
a71dc45 to
b6cb9bc
Compare
I've rebased this pull request #23300, did some fixes and testet it with real hardware. It seems to work well on the bench, I will do a few real word flight test & comparisons next week and report as well.