Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blended backend a real backend #26919

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

peterbarker
Copy link
Contributor

Tested in SITL.

Board               AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       352    *           184     304               328    352    360
Hitec-Airspeed      *                                                                     
KakuteH7-bdshot                480    *           496     472               656    472    472
MatekF405                      56     *           128     128               -96    80     104
Pixhawk1-1M-bdshot             96                 120     104               64     104    104
f103-QiotekPeriph   *                                                                     
f303-Universal      *                                                                     
iomcu                                                           *                         
revo-mini                      64     *           -96     8                 16     0      104
skyviper-v2450                                    *                                       

Copy link
Contributor

@amilcarlucas amilcarlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool changes!

libraries/AP_GPS/AP_GPS_Blended.h Outdated Show resolved Hide resolved
libraries/AP_GPS/AP_GPS_Blended.h Outdated Show resolved Hide resolved
@tridge
Copy link
Contributor

tridge commented Apr 30, 2024

we will do some SpringValley flight testing

@peterbarker peterbarker force-pushed the pr/blended-backend branch from 6d4cf64 to 5c6c678 Compare May 1, 2024 00:29
@peterbarker peterbarker force-pushed the pr/blended-backend branch from 5c6c678 to 23ef206 Compare June 2, 2024 00:52
@peterbarker peterbarker force-pushed the pr/blended-backend branch 2 times, most recently from 15f7df7 to 535744d Compare July 7, 2024 04:42
@peterbarker
Copy link
Contributor Author

Flight testing at SV went well today.

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this interact with EKF3 affinity?

@@ -606,7 +604,7 @@ class AP_GPS
protected:

// configuration parameters
Params params[GPS_MAX_RECEIVERS];
Params params[GPS_MAX_INSTANCES];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove GPS_MAX_RECEIVERS now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. There are all sorts of interesting decisions to be made revolving around it.

Many of them will end up turning into a :-style iteration across the instances array.

@tridge
Copy link
Contributor

tridge commented Jul 15, 2024

I'd like to understand how this interacts with affinity

@peterbarker peterbarker force-pushed the pr/blended-backend branch 2 times, most recently from 8b53432 to de1a9bc Compare July 16, 2024 12:02
@amilcarlucas
Copy link
Contributor

Is this planned for 4.6?

@peterbarker peterbarker force-pushed the pr/blended-backend branch 2 times, most recently from 61f5699 to 06ef30a Compare August 20, 2024 04:08
@peterbarker
Copy link
Contributor Author

I've flown a real copter with blended a bunch now - even with different GPS types it copes.

I've added an autotest that tests blended/affinity before and after.

The logs on master show that when affinity is in play the third core will use the blended GPS.

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Aug 26, 2024

I tested this in SITL a while back using some of the SIM* params to muck with the GPS health of GPS 1 and 2 and could not get the vehicle to have any serious issues with blended. I was wanting triple-GPS support, and was interested in this.
I haven't tested the latest version.

The new test is nice to ensure GPS errors get blended out.

@tridge tridge merged commit 14e5fd3 into ArduPilot:master Aug 26, 2024
93 checks passed
@peterbarker peterbarker deleted the pr/blended-backend branch August 26, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants