-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start Surface Distance Library #26933
Conversation
This is looking good! Let's call the new library "AP_SurfaceDistance" because we will likely use it in Plane as well. |
maybe a SURF log message? with instance number |
Key things to test are:
|
3bee0d2
to
cceaf50
Compare
Renamed to AP_SurfaceDistance and added logging. For logging I have added a status bitmask which should make it easier to track various fault conditions. |
Definitely want this in Plane! |
cceaf50
to
b65085a
Compare
This is great work! I would love to see sub use this in a future PR. |
b65085a
to
426c948
Compare
426c948
to
b2c05c9
Compare
I have flight tested this code (git hash: 426c948) All appears to working as before. Here is a break down of the test: log file here: https://drive.google.com/file/d/1myPkiXPjzz0Ay9KEJwMSnXHhpa4FlaGW/view?usp=sharing |
b2c05c9
to
78b2bb4
Compare
78b2bb4
to
a67971d
Compare
Apologies, I cannot make the call this evening, but this PR has been through a few reviews now and I am hopeful that it is good to go.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see the testing results! Thanks!
Following on from the discussion in this PR: #26827, it was agreed that the best way forward was to move the copter rangefinder functionality into a library (we called it AP_HAGL then). This PR is the start of that process.
No functional change should result from this PR
As his way, @IamPete1 already had a branch for it! #20535
I have rebased his original PR to get this. I will continue the work and do the testing.